Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Supports running advanced_cluster_tpf resource with tests in advancedcluster package #2786

Merged
merged 7 commits into from
Nov 8, 2024
Merged

test: Supports running advanced_cluster_tpf resource with tests in advancedcluster package #2786

merged 7 commits into from
Nov 8, 2024

Conversation

EspenAlbert
Copy link
Collaborator

@EspenAlbert EspenAlbert commented Nov 8, 2024 •
edited
Loading

Description

Supports running advanced_cluster_tpf resource with tests in advancedcluster package.
Uses a new flag MONGODB_ATLAS_TPF_ADV_CLUSTER_TESTS to determine if we are in the tpf job

Link to any related issue(s): CLOUDP-283271

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments (screenshots of runs in a different testing repo)

image image image image

@EspenAlbert EspenAlbert marked this pull request as ready for review November 8, 2024 08:28
@EspenAlbert EspenAlbert requested a review from a team as a code owner November 8, 2024 08:28
cveticm
cveticm reviewed Nov 8, 2024
View reviewed changes
internal/testutil/acc/pre_check.go Outdated
tb.Helper()
return func() {
if os.Getenv("MONGODB_ATLAS_TPF_ADV_CLUSTER_TESTS") == "true" {
tb.Skip("Skipping TPF Advanced Cluster tests")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: My understanding is not that we are skipping TPF advanced cluster tests but that we don't run tests on TPF advanced clusters at all. Is this a correct assumption? If so, I think a message more along the lines of "Skipping tests as resource is TPF Advanced Cluster" would make this more explicit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! Updated in 053deb3, WDYT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Tag/DM if you want an update otherwise I might not see it 😅

lantoli
lantoli approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@lantoli lantoli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like it! thanks for the follow-ups

@EspenAlbert EspenAlbert merged commit 01b0cc7 into master Nov 8, 2024
38 checks passed
@EspenAlbert EspenAlbert deleted the CLOUDP-283271_advanced_cluster_tpf_testing branch November 8, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cveticm cveticm cveticm left review comments

@lantoli lantoli lantoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EspenAlbert @lantoli @cveticm